Fix concurrent usage of JSON::Coder#dump#874
Merged
byroot merged 1 commit intoruby:masterfrom Oct 25, 2025
Merged
Conversation
byroot
force-pushed
the
coder-reset-nesting
branch
from
e301483 to
75c7c0f
Compare
4 tasks
Fix: rails/rails@9061627#r168784389 Because the `depth` counter is inside `JSON::State` it can't be used concurrently, and in case of a circular reference the counter may be left at the max value. The depth counter should be moved outside `JSON_Generator_State` and into `struct generate_json_data`, but it's a larger refactor. In the meantime, `JSON::Coder` calls `State#generate_new` so I changed that method so that it first copy the state on the stack.
byroot
force-pushed
the
coder-reset-nesting
branch
from
75c7c0f to
aefa671
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: rails/rails@9061627#r168784389
Because the
depthcounter is insideJSON::Stateit can't be used concurrently, and in case of a circular reference the counter may be left at the max value.The depth counter should be moved outside
JSON_Generator_Stateand intostruct generate_json_data, but it's a larger refactor.In the meantime,
JSON::CodercallsState#generate_newso I changed that method so that it first copy the state on the stack.FYI: @chaadow