Skip to content

Small JRuby build fixes#866

Merged
byroot merged 3 commits intoruby:masterfrom
headius:jruby_rakefile_fixes
Sep 20, 2025
Merged

Small JRuby build fixes#866
byroot merged 3 commits intoruby:masterfrom
headius:jruby_rakefile_fixes

Conversation

@headius
Copy link
Copy Markdown
Contributor

@headius headius commented Sep 19, 2025

Two fixes here:

@headius
Add JRuby build output to CLEAN and CLOBBER
a2aa1cb
@headius
Use --release flag on Java 9+
b1cc126 
The check for the modules dir here indicates whether we are on JDK
9+, since 1.8 did not have modules.

Fixes ruby#862.

See ruby#859 for some background.
@headius headius force-pushed the jruby_rakefile_fixes branch 2 times, most recently from 502b83b to 07f5519 Compare September 20, 2025 00:46
@headius headius force-pushed the jruby_rakefile_fixes branch from 07f5519 to 3d1ed18 Compare September 20, 2025 00:50
@headius
Copy link
Copy Markdown
Contributor Author

headius commented Sep 20, 2025

@byroot I don't think rake clean and rake clobber are cleaning anything for CRuby either:

[] json $ ls tmp
arm64-darwin24
[] json $ cx 3.4.5 rake clean  
[] json $ ls tmp
arm64-darwin24

@headius headius mentioned this pull request Sep 20, 2025
Closed
@headius
Copy link
Copy Markdown
Contributor Author

headius commented Sep 20, 2025

This is good to go. I did not make any changes to fix rake clean and rake clobber on CRuby.

@byroot byroot merged commit bb5db85 into ruby:master Sep 20, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Modify JRuby ext build to specify JDK release version

2 participants

@headius @byroot