fix for pretty_generate throwing wrong number of arguments error#803
Merged
byroot merged 1 commit intoruby:masterfrom May 16, 2025
CodyBriscoe:bugfix/pretty_generate
Merged
fix for pretty_generate throwing wrong number of arguments error#803byroot merged 1 commit intoruby:masterfrom CodyBriscoe:bugfix/pretty_generate
byroot merged 1 commit intoruby:masterfrom
CodyBriscoe:bugfix/pretty_generate
Conversation
Member
|
Oh, that's a dumb mistake. Could you add a regression test? I can release the fix quickly. |
Author
|
Sure thing, will have that up in a moment |
Author
|
@byroot let me know if you want anything tweaked or added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found this error to first appear in 2.11.0 as a breaking change in one of our codebases.
When
State === optsis false, pretty_generate would eventually call generate with 3 arguments:State.generate(obj, options, nil)However if
State === opts, it would originally try to callstate.generate(obj)with only one argument. However,statejust returns the State class itselfJSON::Ext::Generator::Stateand expects 3 arguments.This change aligns the behavior with the regular JSON.generate method to call
opts.generateinstead.