Stop caching the generator state pointer#791
Merged
byroot merged 1 commit intoruby:masterfrom Apr 25, 2025
Merged
Conversation
Fix: ruby#790 If we end up calling something that spills the state on the heap, the pointer we received is outdated and may be out of sync.
byroot
force-pushed
the
fix-pretty-generate
branch
from
51a25d1 to
2ffa4ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #790
If we end up calling something that spills the state on the heap, the pointer we received is outdated and may be out of sync.