Limit the size of ParserError exception messages#625
Merged
byroot merged 2 commits intoruby:masterfrom Oct 18, 2024
Merged
Conversation
casperisfine
force-pushed
the
limit-error-message
branch
from
039d5ff to
7c7237b
Compare
Fix: ruby#534 Only include up to 32 bytes of unparseable the source.
casperisfine
force-pushed
the
limit-error-message
branch
from
7c7237b to
f44995c
Compare
Contributor
|
Thank you for continuing to patch the JRuby ext as well! Please ping me if there's any bug or optimization you think I should look into. |
Author
|
Note that I'm only doing the minimum required to keep the test suite passing, I'm not looking at all at the performance of it. On that front I consider you to be the maintainer of the Java backend. |
Author
|
Not that I don't want to, but my Java skills are primitive at best and it's not in my plan to spend the time to develop a Java expertise. |
casperisfine
pushed a commit
to casperisfine/json
that referenced
this pull request
Oct 21, 2024
Fix: ruby#625 Declaring the buffer in a sub block cause bugs on some compilers.
casperisfine
pushed a commit
to casperisfine/json
that referenced
this pull request
Oct 21, 2024
Fix: ruby#625 Declaring the buffer in a sub block cause bugs on some compilers.
casperisfine
pushed a commit
to casperisfine/json
that referenced
this pull request
Oct 21, 2024
Fix: ruby#625 Declaring the buffer in a sub block cause bugs on some compilers.
hsbt
pushed a commit
to hsbt/ruby
that referenced
this pull request
Oct 26, 2024
Fix: ruby/json#625 Declaring the buffer in a sub block cause bugs on some compilers. ruby/json@90967c9eb0
hsbt
pushed a commit
to hsbt/ruby
that referenced
this pull request
Oct 26, 2024
Fix: ruby/json#625 Declaring the buffer in a sub block cause bugs on some compilers. ruby/json@90967c9eb0
hsbt
pushed a commit
to ruby/ruby
that referenced
this pull request
Oct 26, 2024
Fix: ruby/json#625 Declaring the buffer in a sub block cause bugs on some compilers. ruby/json@90967c9eb0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #534
Only include up to 32 bytes of the unparseable source.