Conversation
|
I also noticed the docs in https://github.com/flori/json/blob/4f876a8bf7c45972800bae5bdbaf892aa2f714a5/lib/json/pure/generator.rb#L222 are wrong, could you fix that too? And the alignment in https://github.com/flori/json/blob/4f876a8bf7c45972800bae5bdbaf892aa2f714a5/lib/json/pure/generator.rb#L143 is inconsistent (I dislike this kind of alignment, too high maintenance and diff noise, but might as well be consistent in one way, i.e. all or none aligned) |
I'd rather not bundle multiple unrelated fixes in the same PR. Makes merging more complicated. |
|
Ah sorry, it's OTOH I think fixing the description of |
db37392 to
937900c
Compare
937900c to
3652866
Compare
Followup: #519
Fix: #584