Fix a false negative for Rails/EnvLocal when having preceding conditions
#1499
+99
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Jul 12, 2025
lib/rubocop/cop/rails/env_local.rb
Outdated
| end | ||
|
|
||
| def offense_range(nodes) | ||
| range_between(nodes[1].source_range.begin_pos, nodes[0].source_range.end_pos) |
Member
There was a problem hiding this comment.
In this case, doing it this way also allows you to remove include RangeHelp on L20, making it simpler.
Suggested change
| range_between(nodes[1].source_range.begin_pos, nodes[0].source_range.end_pos) | |
| nodes[1].source_range.begin.join(nodes[0].source_range.end) |
koic
reviewed
Jul 12, 2025
lib/rubocop/cop/rails/env_local.rb
Outdated
| class EnvLocal < Base | ||
| extend AutoCorrector | ||
| extend TargetRailsVersion | ||
| include RangeHelp |
Member
There was a problem hiding this comment.
Updating L89 allows this line to be removed.
Suggested change
| include RangeHelp |
fatkodima
force-pushed
the
fix-false-negative-for-env_local
branch
from
426069a to
8fcb712
Compare
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1478.