Don't load the active_support blank core extension
#1467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rubocop already defined its own `blank?` method (🙁), so ruby always warns when it is loaded again. There's no real point in using the extension though, so just not using it seems ideal.
9 tasks
Earlopain
added a commit
to Earlopain/rubocop-rails
that referenced
this pull request
May 7, 2025
…mment is passed as a local variable To do that, be more specific about what type you expect to call blank? on (strings only). Caused by rubocop#1467
9 tasks
Earlopain
added a commit
to Earlopain/rubocop-rails
that referenced
this pull request
May 8, 2025
…mment is passed as a local variable To do that, be more specific about what type you expect to call blank? on (strings only). Caused by rubocop#1467
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rubocop already defined its own
blank?method (🙁), so ruby always warns when it is loaded again.There's no real point in using the extension though, so just not using it seems ideal.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.