Skip to content

Conversation

@koic
Copy link
Member

@koic koic commented Oct 27, 2025

This PR fixes the following error for Style/SoleNestedConditional when using nested single line if:

$ echo "if foo; if bar; end; end" | bundle exec rubocop --stdin example.rb --only Style/SoleNestedConditional -A -d
(snip)

Inspecting 1 file
Scanning /Users/koic/src/github.com/rubocop/rubocop/example.rb
An error occurred while Style/SoleNestedConditional cop was inspecting
/Users/koic/src/github.com/rubocop/rubocop/example.rb:1:0.
/Users/koic/.rbenv/versions/3.5-dev/lib/ruby/gems/3.5.0+4/gems/parser-3.3.10.0/lib/parser/source/tree_rewriter.rb:427:
in 'Parser::Source::TreeRewriter#trigger_policy': Parser::Source::TreeRewriter detected clobbering (Parser::ClobberingError)

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This PR fixes the following error for `Style/SoleNestedConditional`
when using nested single line `if`:

```console
$ echo "if foo; if bar; end; end" | bundle exec rubocop --stdin example.rb --only Style/SoleNestedConditional -A -d
(snip)

Inspecting 1 file
Scanning /Users/koic/src/github.com/rubocop/rubocop/example.rb
An error occurred while Style/SoleNestedConditional cop was inspecting
/Users/koic/src/github.com/rubocop/rubocop/example.rb:1:0.
/Users/koic/.rbenv/versions/3.5-dev/lib/ruby/gems/3.5.0+4/gems/parser-3.3.10.0/lib/parser/source/tree_rewriter.rb:427:
in 'Parser::Source::TreeRewriter#trigger_policy': Parser::Source::TreeRewriter detected clobbering (Parser::ClobberingError)
```
@bbatsov bbatsov merged commit 300e29b into rubocop:master Oct 27, 2025
22 checks passed
@koic koic deleted the fix_an_error_for_style_sole_nested_conditional branch October 27, 2025 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants