[Fix #14563] Fix an incorrect autocorrect for Lint/DeprecatedOpenSSLConstant
#14564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OpenSSLConstant` This PR fixes an incorrect autocorrect for `Lint/DeprecatedOpenSSLConstant` when using twice `Cipher` constant. Fixes rubocop#14563.
koic
force-pushed
the
fix_an_incorrect_autocorrect_for_lint_deprecated_open_ssl_constant
branch
from
23c0667 to
42ff7a4
Compare
Contributor
|
Can you update documentation? This constant has actually been deprecated nine years ago (https://github.com/ruby/openssl/blame/4b923b470e3b1e18d23fc43e46804ede0d97bc83/lib/openssl/cipher.rb#L60-L65) but I don't think it was the intention of the cop initially to catch this (hence no docs) |
bbatsov
approved these changes
Sep 26, 2025
koic
deleted the
fix_an_incorrect_autocorrect_for_lint_deprecated_open_ssl_constant
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an incorrect autocorrect for
Lint/DeprecatedOpenSSLConstantwhen using twiceCipherconstant.Fixes #14563.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.