Fix the built-in Ruby LSP add-on not respecting .rubocop config file
#14514
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user specifies
-c foo.yml, it should be used.This consolidates option/cli handling to
apply_options!. That wayforce_default_configis consistenly used as well.That now also happens when generating a todo. It seems correct for consistency, but I didn't add a test for it and am ok with dropping that change.
Apart from this, I'm only aware of one extra difference between the ruby-lsp addons but it requires a change in ruby-lsp itself: Shopify/ruby-lsp#3736
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.