Skip to content

Conversation

@Earlopain
Copy link
Contributor

If the user specifies -c foo.yml, it should be used.

This consolidates option/cli handling to apply_options!. That way force_default_config is consistenly used as well.

That now also happens when generating a todo. It seems correct for consistency, but I didn't add a test for it and am ok with dropping that change.

Apart from this, I'm only aware of one extra difference between the ruby-lsp addons but it requires a change in ruby-lsp itself: Shopify/ruby-lsp#3736


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

If the user specifies `-c foo.yml`, it should be used.

This consolidates option/cli handling to `apply_options!`.
That way `force_default_config` is consistenly used as well.

That now also happens when generating a todo. It seems correct for consistency, but I didn't add a test for it and am ok with dropping that change.
@koic koic merged commit 10bf0c5 into rubocop:master Sep 9, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants