[Fix #14502] Fix wrong autocorrect for Style/StringConcatenation when a single-quoted string contains interpolation
#14504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Sep 3, 2025
Comment on lines
308
to
328
| it 'registers an offense for `#$`' do | ||
| expect_offense(<<~'RUBY') | ||
| "foo" + '#$bar' | ||
| ^^^^^^^^^^^^^^^ Prefer string interpolation to string concatenation. | ||
| RUBY | ||
|
|
||
| expect_correction(<<~'RUBY') | ||
| "foo\#$bar" | ||
| RUBY | ||
| end | ||
|
|
||
| it 'registers an offense for `#@`' do | ||
| expect_offense(<<~'RUBY') | ||
| "foo" + '#@bar' | ||
| ^^^^^^^^^^^^^^^ Prefer string interpolation to string concatenation. | ||
| RUBY | ||
|
|
||
| expect_correction(<<~'RUBY') | ||
| "foo\#@bar" | ||
| RUBY | ||
| end | ||
|
|
||
| it 'registers an offense for `#@@`' do | ||
| expect_offense(<<~'RUBY') | ||
| "foo" + '#@@bar' | ||
| ^^^^^^^^^^^^^^^^ Prefer string interpolation to string concatenation. | ||
| RUBY | ||
|
|
||
| expect_correction(<<~'RUBY') | ||
| "foo\#@@bar" | ||
| RUBY | ||
| end |
Member
There was a problem hiding this comment.
Good test cases. That's my two cents. Can you arrange them by scope, starting with the narrowest and ending with the widest?
Suggested change
| it 'registers an offense for `#$`' do | |
| expect_offense(<<~'RUBY') | |
| "foo" + '#$bar' | |
| ^^^^^^^^^^^^^^^ Prefer string interpolation to string concatenation. | |
| RUBY | |
| expect_correction(<<~'RUBY') | |
| "foo\#$bar" | |
| RUBY | |
| end | |
| it 'registers an offense for `#@`' do | |
| expect_offense(<<~'RUBY') | |
| "foo" + '#@bar' | |
| ^^^^^^^^^^^^^^^ Prefer string interpolation to string concatenation. | |
| RUBY | |
| expect_correction(<<~'RUBY') | |
| "foo\#@bar" | |
| RUBY | |
| end | |
| it 'registers an offense for `#@@`' do | |
| expect_offense(<<~'RUBY') | |
| "foo" + '#@@bar' | |
| ^^^^^^^^^^^^^^^^ Prefer string interpolation to string concatenation. | |
| RUBY | |
| expect_correction(<<~'RUBY') | |
| "foo\#@@bar" | |
| RUBY | |
| end | |
| it 'registers an offense for `#@`' do | |
| expect_offense(<<~'RUBY') | |
| "foo" + '#@bar' | |
| ^^^^^^^^^^^^^^^ Prefer string interpolation to string concatenation. | |
| RUBY | |
| expect_correction(<<~'RUBY') | |
| "foo\#@bar" | |
| RUBY | |
| end | |
| it 'registers an offense for `#@@`' do | |
| expect_offense(<<~'RUBY') | |
| "foo" + '#@@bar' | |
| ^^^^^^^^^^^^^^^^ Prefer string interpolation to string concatenation. | |
| RUBY | |
| expect_correction(<<~'RUBY') | |
| "foo\#@@bar" | |
| RUBY | |
| end | |
| it 'registers an offense for `#$`' do | |
| expect_offense(<<~'RUBY') | |
| "foo" + '#$bar' | |
| ^^^^^^^^^^^^^^^ Prefer string interpolation to string concatenation. | |
| RUBY | |
| expect_correction(<<~'RUBY') | |
| "foo\#$bar" | |
| RUBY | |
| end |
Contributor
Author
There was a problem hiding this comment.
Sure, I moved globals to be last.
…ion` when a single-quoted string contains interpolation This only escapes `#` when it looks like interpolation, not all the time. If it turns out to not be interpolation after all, `Style/RedundantStringEscape` will take care of it.
Earlopain
force-pushed
the
string-concant-single-quotes-interpolation
branch
from
8cdf802 to
996eeec
Compare
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14502
This only escapes
#when it looks like interpolation, not all the time. If it turns out to not be interpolation after all,Style/RedundantStringEscapewill take care of it.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.