[Fix #14499] Fix wrong autocorrect for Style/StringConcatenation with escaped quotes and interpolation
#14500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Sep 2, 2025
| "\#{#{part.source}}" | ||
| end | ||
| adjust_str(part) | ||
| end |
Member
There was a problem hiding this comment.
Nits: The following one-liner is simpler.
interpolated_parts = parts.map { |part| adjust_str(part) }
…ion` with escaped quotes and interpolation The dstr parts also need to have their content adjusted since they may contains strings. This slightly changes one autocorrect expectation, but the parens inside of the interpolation are redundant so there is no problem removing them.
Earlopain
force-pushed
the
string-concat-escaped
branch
from
3776724 to
2f2f63a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14499
The dstr parts also need to have their content adjusted since they may contains strings.
This slightly changes one autocorrect expectation, but the parens inside of the interpolation
are redundant so there is no problem removing them.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.