[Fix #14435] Fix false negatives for regexp cops when Lint/DuplicateRegexpCharacterClassElement is enabled
#14437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlopain
force-pushed
the
regexp-expression-modification
branch
from
ee74513 to
87206b7
Compare
Contributor
Author
|
I froze the expressions to check if there are other cops that modify them but that doesn't seem to be the case now. Can't commit that though, since one of the monkey-patches for them does |
Earlopain
force-pushed
the
regexp-expression-modification
branch
from
87206b7 to
dd069ef
Compare
Earlopain
changed the title
Lint/DuplicateRegexpCharacterClassElement is enabledLint/DuplicateRegexpCharacterClassElement is enabled
Collaborator
|
@Earlopain Shouldn't we add some tests covering the false negatives that were fixed?
I find this part confusing. :D |
…plicateRegexpCharacterClassElement` is enabled It does `expressions = expressions.to_a`, which does not create a copy. So other cops that run after would not see all the expressions. `.dup` would solve this, but all this does is work around a bug in `regexp_parser` < 2.7.0. RuboCop now requires >= 2.9.3 so all that code can simply be removed. I didn't add a new test because the code that would be tested is gone now. Also see rubocop#13875 for something quite similar.
Earlopain
force-pushed
the
regexp-expression-modification
branch
from
dd069ef to
32815b4
Compare
Contributor
Author
There was a PR that accidentally introduced regexp ast modifications and I basically reverted that since it's no longer necessary. Anyways, I added a test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14435
It does
expressions = expressions.to_a, which does not create a copy. So other cops that run after would not see allthe expressions.
.dupwould solve this, but all this does is work around a bug inregexp_parser< 2.7.0. RuboCop now requires >= 2.9.3 so all that code can simply be removed.I didn't add a new test because the code that would be tested is gone now.
Also see #13875 for something quite similar.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.