Repository navigation
fix(opencode): discover project directory permission configs - #4856
Open
superbiche wants to merge 1 commit into
Open
superbiche wants to merge 1 commit into
superbiche wants to merge 1 commit into
Conversation
Co-Authored-By: GPT 6.1 Sol (via Liaison fleet) <[email protected]>
📊 Automated PR Analysis
SummaryFixes OpenCode permission discovery in Review Checklist
Linked issues: #4855 Analyzed automatically by wshm · This is an automated analysis, not a human review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rtk hook opencodenow discovers project permissions in.opencode/opencode.json(c)directories, not only direct ancestoropencode.json(c)files, so a project-level deny or ask is seen by the before/after verdict comparison and the rewrite is skipped ({})..opencodedirectories outermost first,opencode.jsonbeforeopencode.jsoncin each directory. Global config andOPENCODE_CONFIGsemantics are unchanged.Fixes #4855 (deny lifted when the project policy lives in
.opencode/).Test plan
cargo fmt --all && cargo clippy --all-targets && cargo test— not run locally; this patch was prepared from source inspection in an environment that does not build the crate. Please rely on CI and tell me if anything fails, I will follow up.rtk1.1.0 reproduces the defect ({"command":"rtk git diff"}under a.opencode/opencode.jsondeny,{}under./opencode.json); the patch applies cleanly ondevelop(7e92da0) andgit diff --checkis clean.@superbiche · user · drafted with Claude Fable 5.1, reviewed before posting; the voice and decisions are mine.