fix: propagate linter exit code in rtk lint#207
Merged
pszymkowiak merged 1 commit intortk-ai:masterfrom Feb 18, 2026
Merged
Conversation
b0ff25c to
cc0d6b0
Compare
rtk lint was always returning exit code 0 regardless of the underlying linter's exit status, causing false-green CI behavior when lint should fail. Uses !output.status.success() pattern consistent with all other RTK modules, which correctly handles both non-zero exit codes and signal termination. Fixes rtk-ai#185 Co-Authored-By: Claude Opus 4.6 <[email protected]>
cc0d6b0 to
513b7ef
Compare
Contributor
Author
|
Note on CI The This PR only touches |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rtk lintwas always returning exit code 0 regardless of the underlying linter's exit status!output.status.success()patternRoot Cause
The
run()function inlint_cmd.rscaptured the exit code for tee output but never used it to set the process exit status — it always returnedOk(())(exit 0).Fix
Added 3 lines after tracking, matching the exact pattern used by every other RTK module (git, cargo, playwright, vitest, etc.):
Why
!status.success()instead ofexit_code != 0Per Rust stdlib docs,
ExitStatus::code()returnsNonewhen a process is terminated by signal.!success()correctly detects failure in all cases (non-zero exit AND signal termination), while!= 0depends on theunwrap_orfallback value.Test plan
cargo test lint_cmd)rtk lint npx eslint <file> --max-warnings=0returns non-zero exit codertk lint npx eslint <clean-file>still returns exit code 0Fixes #185
🤖 Generated with Claude Code