Moved generic traits and structs here, moved to mutex-trait #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
bors try |
Contributor
tryBuild succeeded: |
Contributor
Author
|
|
japaric
reviewed
Apr 21, 2020
Collaborator
japaric
left a comment
japaric
left a comment
There was a problem hiding this comment.
Mostly looks good to me but the MultiCore trait should be hidden behind an unstable Cargo feature since it's part of the experimental multi-core support in cortex-m-rtfm. We'd like to reserve the right to change this one trait.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.