Skip to content

Conversation

@japaric
Copy link
Collaborator

@japaric japaric commented Jan 15, 2018

No description provided.

@japaric
Copy link
Collaborator Author

japaric commented Jan 15, 2018

@homunkulus r+

@homunkulus
Copy link
Contributor

📌 Commit def4fc8 has been approved by japaric

@homunkulus
Copy link
Contributor

⌛ Testing commit def4fc8 with merge b73263e...

japaric pushed a commit that referenced this pull request Jan 15, 2018
@homunkulus
Copy link
Contributor

☀️ Test successful - status-travis
Approved by: japaric
Pushing b73263e to master...

@homunkulus homunkulus merged commit def4fc8 into master Jan 15, 2018
@japaric japaric deleted the v3 branch January 15, 2018 22:48
//! The `app!` macro is documented [here].
//!
//! [here]: https://docs.rs/cortex-m-rtfm-macros/0.2.0/cortex_m_rtfm_macros/fn.app.html
//! [here]: https://docs.rs/cortex-m-rtfm-macros/0.2.1/cortex_m_rtfm_macros/fn.app.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You bumped the version to 0.3.0 but this refers to 0.2.1

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-(

[dependencies]
cortex-m = { git = "https://github.com/japaric/cortex-m" }
cortex-m = "0.4.0"
cortex-m-rtfm-macros = "0.3.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it not possible to keep the path dependency? I think Cargo will automatically rewrite it and publish both crates together.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can try that next time.

andrewgazelka pushed a commit to andrewgazelka/cortex-m-rtic that referenced this pull request Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants