Conversation
This reverts commit 4dc3fcb. scipy fails to build otherwise.
|
I am getting errors for EDIT: These don't happen consistently. |
|
I sometimes get the following error: as well as the memory access out of bounds error with |
|
The only consistently reproducible error is I think the PR can be merged and this can be sorted out later. |
|
Of course the test can be made to pass by simply increasing the recursion limit, but I don't know if we want to do that. |
|
Thanks! I gave you write access to my fork, so don't hesitate to push commits to pyodide#480 directly.
Yes, those also happen occasionally on master in Chrome pyodide#729 so it's not an immediate concern.
yes, that part is a bit brittle. We already have a fix for the recursion limit in https://github.com/iodide-project/pyodide/blob/09d56a2d6429801e8954576d560db59637d176ce/src/pyodide.js#L273 but it's true that I have seen this error occasionally in the past. |
I'll undraft this when all tests pass (or it is clear that much more work is needed to make all tests pass)