avoid piping in data via stdin to avoid stderr redirection bug in node 7's child process

michaelglass · michaelglass · commit 959fda06c99a · 2017-02-08T17:18:53.000-08:00
diff --git a/bin/elm-test b/bin/elm-test
@@ -11,7 +11,8 @@ var compile    = require("node-elm-compiler").compile,
   temp         = require("temp").track(), // Automatically cleans up temp files.
   util         = require("util"),
   _            = require("lodash"),
-  childProcess = require("child_process");
+  childProcess = require("child_process"),
+  findup       = require("findup-sync");
 
 var elm = {
   'elm-package': 'elm-package'
@@ -102,23 +103,24 @@ temp.open({ prefix:'elm_test_', suffix:'.js' }, function(err, info) {
 
     console.log("Successfully compiled", testFile);
 
-    var runnerOpts = {stdio: ["pipe", "inherit", "inherit"]};
-    var runnerProcess = childProcess.spawn("node", [], runnerOpts);
+    // append suffix to temp file
+    fs.appendFile(dest, suffix, function(err){
+      if (err) throw(err);
 
-    runnerProcess.on('exit', function (exitCode) {
-      process.exit(exitCode);
-    });
+      console.log("Bootstrapped test script")
 
-    var reader = fs.createReadStream(dest);
+      // add node_modules to NODE_PATH so the temporary file can require
+      // local modules
+      var pathToNodeModules = findup("node_modules");
+      process.env.NODE_PATH = _.compact([process.env.NODE_PATH, pathToNodeModules]).join(':');
 
-    reader.on("end", function() {
-      runnerProcess.stdin.write(suffix);
+      var runnerProcess = childProcess.spawn("node", [dest], {stdio: 'inherit'});
 
-      runnerProcess.stdin.end();
-    })
+      runnerProcess.on('exit', function (exitCode) {
+        process.exit(exitCode);
+      });
 
-    reader.pipe(runnerProcess.stdin);
-
-    console.log("Running tests...");
+      console.log("Running tests...");
+    });
   });
 });
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "elm-test",
-  "version": "0.16.0",
+  "version": "0.16.1",
   "description": "Run elm-test suites.",
   "main": "elm-test.js",
   "engines": {
@@ -31,6 +31,7 @@
     "fs-extra": "0.26.2",
     "lodash": "3.10.1",
     "node-elm-compiler": "2.0.0",
-    "temp": "0.8.3"
+    "temp": "0.8.3",
+    "findup-sync": "0.4.3"
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "elm-test",`
`3`		`- "version": "0.16.0",`
	`3`	`+ "version": "0.16.1",`
`4`	`4`	`"description": "Run elm-test suites.",`
`5`	`5`	`"main": "elm-test.js",`
`6`	`6`	`"engines": {`
`@@ -31,6 +31,7 @@`
`31`	`31`	`"fs-extra": "0.26.2",`
`32`	`32`	`"lodash": "3.10.1",`
`33`	`33`	`"node-elm-compiler": "2.0.0",`
`34`		`- "temp": "0.8.3"`
	`34`	`+ "temp": "0.8.3",`
	`35`	`+ "findup-sync": "0.4.3"`
`35`	`36`	`}`
`36`	`37`	`}`