Skip to content

Labs: GitHub-177: Add functionality to define constant to enable nginx logging #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vishalkakadiya merged 18 commits into from
Jan 17, 2024
Merged

Labs: GitHub-177: Add functionality to define constant to enable nginx logging #316

vishalkakadiya merged 18 commits into from
Jan 17, 2024

Conversation

@vishalkakadiya
Copy link
Contributor

@vishalkakadiya vishalkakadiya commented Jan 12, 2024 •
edited
Loading

As discussed over the call on the 11th of January:

  • Adds functionality to define the NGINX_HELPER_LOG constant in the wp-config file to enable the logging feature.
  • Users who are already using the nginx-helper plugin with Enable Logging will not be affected, but if they disable the logging then they need to define the NGINX_HELPER_LOG constant to enable the logging feature again.

Ref: https://github.com/rtCamp/labs/issues/177

@vishalkakadiya vishalkakadiya mentioned this pull request Jan 12, 2024
Closed
gagan0123
gagan0123 requested changes Jan 12, 2024
View reviewed changes
gagan0123
gagan0123 requested changes Jan 12, 2024
View reviewed changes
@vishalkakadiya vishalkakadiya merged commit e1ab3ee into develop Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gagan0123 gagan0123 gagan0123 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vishalkakadiya @gagan0123