Skip to content

Add wildcard cache key deletion for device type cache purge#203

Merged
pradeep910 merged 2 commits intomasterfrom
feature/add-wildcard-keys-deletion
Jul 1, 2019
Merged

Add wildcard cache key deletion for device type cache purge#203
pradeep910 merged 2 commits intomasterfrom
feature/add-wildcard-keys-deletion

Conversation

@pradeep910
Copy link
Collaborator

@pradeep910 pradeep910 commented Apr 26, 2019 •
edited
Loading

Adds wildcard check to delete device type cache such as <URL>--*.

This requires following filter as URLs will not contain --* by default.

add_filter( 'rt_nginx_helper_purge_url', function( $url ) {
       // Add wildcard in cache key URL for all device type keys deletion.
       $url = $url . '--*';
       return $url;
});

For #202

chandrapatel
chandrapatel suggested changes Apr 26, 2019
View reviewed changes
@pradeep910 pradeep910 requested a review from chandrapatel April 26, 2019 15:27
@radhe
Copy link
Member

radhe commented May 27, 2019

@kirtangajjar @th3karkota
can you do the testing?

@pradeep910 pradeep910 merged commit a871cd4 into master Jul 1, 2019
@pradeep910
Copy link
Collaborator Author

pradeep910 commented Jul 1, 2019

We've merged this plugin after testing it on one of our live sites.
cc @chandrapatel @kirtangajjar @radhe

@thrijith thrijith deleted the feature/add-wildcard-keys-deletion branch July 31, 2019 07:59
@thrijith thrijith mentioned this pull request Jul 31, 2019
Merged
@pradeep910 pradeep910 mentioned this pull request Nov 13, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@chandrapatel chandrapatel chandrapatel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pradeep910 @radhe @chandrapatel