Plugged locations that were sending purge requests even if disabled#168
Merged
chandrapatel merged 1 commit intortCamp:masterfrom Dec 19, 2019
Merged
Conversation
chandrapatel
approved these changes
Dec 19, 2019
Contributor
|
Hi @jaredwsmith Thanks for the PR. I have approved PR and merging PR. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a few locations in nginx-helper (dating back to at least 1.9.10) that were sending requests to
/purge/even if cache purging was disabled in settings. On our environment, this was causing errors and unnecessary load on our infrastructure. My patch simply adds guard conditions toPurger::purge_image_on_edit,Purger::purge_on_taxonomy_term_edited, andPurger::purge_on_check_ajax_referer.