Allow using filters to change the purge url#141
Merged
chandrapatel merged 5 commits intortCamp:masterfrom Dec 19, 2019
stayallive:feature/custom-purge-url
Merged
Allow using filters to change the purge url#141chandrapatel merged 5 commits intortCamp:masterfrom stayallive:feature/custom-purge-url
chandrapatel merged 5 commits intortCamp:masterfrom
stayallive:feature/custom-purge-url
Conversation
Contributor
Author
|
Rebased for |
Contributor
Author
|
It would be very appreciated if this can be looked at and/or be rejected if this is not something that you are willing to accept 👍 |
Contributor
|
Hi @stayallive We will discuss internally and will let you know. Thanks for the PR. |
chandrapatel
suggested changes
Dec 19, 2019
Contributor
chandrapatel
left a comment
There was a problem hiding this comment.
@stayallive My apologies to review PR very late.
I have left few comments on PR. Please check and let me know your thought.
Also please update your PR by merging latest changes from master branch to your branch.
Thanks,
chandrapatel
approved these changes
Dec 19, 2019
Contributor
|
@stayallive Thanks for quickly work on the PR. |
Contributor
Author
|
No problem happy to see it being accepted, this will make plugin updates in the future a lot easier for us :) Thanks! |
Merged
|
@stayallive @chandrapatel thank you very much! 👍🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the user to do 2 things.
/purgesuffix that nginx uses by default:Why both filters? When working with nginx-helper I noticed I often have to change nginx paths algorithm to comply with custom scripting or server changes on our side.
The second filter helps when even the full purge url is different, because of internal networking. Although this happens seldom, the filter helps to mitigate these issues.
Would be great to be able to override it this way instead of hard-coding the changes in 👍