test: add coverage for active BreadcrumbItem with custom component #4462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
Deployment failed with the following error: |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Co-authored-by: simonguo <[email protected]>
|
Deployment failed with the following error: |
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Update BreadcrumbItem implementation based on review feedback
test: add coverage for active BreadcrumbItem with custom component
Dec 10, 2025
simonguo
merged commit d72e776
into
fix/breadcrumb-item-props-forwarding
2 of 6 checks passed
simonguo
added a commit
that referenced
this pull request
Dec 10, 2025
…rumbItem (#4450) * fix(Breadcrumb): forward props correctly when using as prop in BreadcrumbItem - Separate BoxProps and component props using extractBoxProps/omitBoxProps - BoxProps are applied to wrapper element to support layout properties - Component props (like 'to' for react-router Link) are forwarded to inner element - Align prop forwarding behavior with NavItem and DropdownItem - Add test cases for custom component prop forwarding and BoxProps support - Update composition docs to show direct react-router-dom usage Fixes #4427 * refactor(Breadcrumb): rename WrapperComponent to Wrapper in BreadcrumbItem (#4463) * Initial plan * refactor(Breadcrumb): rename WrapperComponent to Wrapper in BreadcrumbItem Co-authored-by: simonguo <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: simonguo <[email protected]> * test: add coverage for active BreadcrumbItem with custom component (#4462) * Initial plan * test: add test for active breadcrumb item with custom component Co-authored-by: simonguo <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: simonguo <[email protected]> --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: simonguo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses missing test coverage for active breadcrumb items using custom components via the
asprop. Whenactive={true}, the component renders a<span>instead of the custom component, but this behavior wasn't tested.Changes
asprop and render as<span>to,data-custom-link) are not applied when active✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.