Skip to content

Conversation

@simonguo
Copy link
Member

@simonguo simonguo commented Dec 9, 2025

This pull request adds a large number of new Storybook stories and improvements to the stories for many UI components. The main focus is on expanding the coverage of component states and features in Storybook, making it easier to test and demonstrate different configurations and behaviors. There are also some minor fixes and improvements to imports and story naming.

Key changes are grouped below by theme:

Storybook Coverage Expansion

  • Added new stories for various states, props, and features across many components, including Sizes, Colors, Bordered, and IconAvatar for Avatar; Searchable, Block, and DefaultExpandAll for picker and tree components; and WithIcons, WithEndIcon, IconOnly, and AsLink for Button. These additions help showcase the full range of component capabilities. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17]
  • Introduced custom rendering and filtering stories for components like AutoComplete, including CustomRender and CustomFilter, to demonstrate advanced usage.
  • Added stories for new features such as bodyFill and ExpandOnlyOnePanel in Accordion, and Invisible, Placement, and Compact in Badge. [1] [2]

Improvements to Story Consistency and Usability

  • Improved story naming for clarity (e.g., fixed typo from Readnly to Readonly and Size to Sizes in AutoComplete).
  • Added missing imports and ensured consistent usage of supporting components like Stack, Badge, and icons in stories. [1] [2] [3] [4]

Bug Fixes and Code Quality

  • Fixed incorrect import paths for Button in ButtonGroup and ButtonToolbar stories. [1] [2]
  • Ensured all stories use the correct Story type and consistent argument spreading for defaultArgs. [1] [2]

Component-Specific Enhancements

  • Added stories for Breadcrumb demonstrating usage with active items, links, and icons.
  • Expanded Calendar stories to include custom cell rendering, ISO week, and week start options.

General Improvements

  • Added default stories where missing for completeness, such as Default in CardGroup.

These changes significantly enhance the documentation and testability of the component library in Storybook, making it easier for developers to understand and utilize all available features.

@codesandbox
Copy link

codesandbox bot commented Dec 9, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 9, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@vercel
Copy link

vercel bot commented Dec 9, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
rsuite-main Ready Ready Preview Comment Dec 9, 2025 10:10am
rsuite-storybook Ready Ready Preview Comment Dec 9, 2025 10:10am

@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.47%. Comparing base (0832f36) to head (583b70e).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4458   +/-   ##
=======================================
  Coverage   94.47%   94.47%           
=======================================
  Files         559      559           
  Lines       13740    13740           
  Branches     4081     4081           
=======================================
  Hits        12981    12981           
  Misses        687      687           
  Partials       72       72           
Flag Coverage Δ
chromium 94.47% <ø> (ø)
firefox 94.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@simonguo simonguo merged commit 7006a5a into main Dec 9, 2025
17 checks passed
@simonguo simonguo deleted the docs/storybook-v6-stories branch December 9, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants