Skip to content

Conversation

@shatishdesai202
Copy link
Contributor

No description provided.

@codesandbox
Copy link

codesandbox bot commented Jun 3, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@vercel
Copy link

vercel bot commented Jun 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rsuite-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2025 0:06am
rsuite-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2025 0:06am

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 3, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@shatishdesai202
Copy link
Contributor Author

image

@simonguo simonguo requested a review from Copilot June 4, 2025 01:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds support for the Gujarati locale (gu_IN) by registering the new locale export and supplying translations plus date formatting.

  • Export the new guIN locale in the central index.
  • Provide full Gujarati translations and integrate with date-fns in gu_IN.ts.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/locales/index.ts Register new guIN locale export
src/locales/gu_IN.ts Define Gujarati translation and patterns
Comments suppressed due to low confidence (3)

src/locales/gu_IN.ts:1

  • Introduce unit or integration tests for the new Gujarati locale to verify translations and date formatting behave as expected.
import guIn from 'date-fns/locale/gu';

src/locales/index.ts:32

  • [nitpick] Align this export with the surrounding lines (add a leading space) to keep formatting consistent with other locale exports.
export { default as guIN } from './gu_IN';

src/locales/gu_IN.ts:22

  • Avoid using as any; import the Locale type from date-fns and cast to it for stronger typing (e.g., dateLocale: guIn as Locale).
dateLocale: guIn as any

@simonguo simonguo merged commit 9715633 into rsuite:main Jun 4, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants