Skip to content

Conversation

@tnitsiri
Copy link
Contributor

Screenshot 2568-05-26 at 01 15 28

@codesandbox
Copy link

codesandbox bot commented May 25, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@vercel
Copy link

vercel bot commented May 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rsuite-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 26, 2025 6:10pm
rsuite-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 26, 2025 6:10pm

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 25, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Member

@simonguo simonguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please export th_TH.ts in index.ts

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds Thai [th_TH] locale to the project, providing translated UI labels and date formatting patterns for Thai users.

  • Introduces th_TH.ts with Thai translations and integrates the date-fns Thai locale.
  • Registers the new thTH export in locales/index.ts.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/locales/th_TH.ts Added Thai translations, date patterns, and locale
src/locales/index.ts Exported thTH to include the new Thai locale
Comments suppressed due to low confidence (1)

src/locales/th_TH.ts:1

  • Add unit tests to verify that the th-TH locale file exports all expected translation keys and that date formatting patterns work as intended.
import th from 'date-fns/locale/th';

last: 'หน้าสุดท้าย',
limit: '{0} / หน้า',
total: 'รายการทั้งหมด: {0}',
skip: 'ไปที่{0}'
Copy link

Copilot AI May 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a space between 'ไปที่' and '{0}' (e.g., 'ไปที่ {0}') to improve readability.

Suggested change
skip: 'ไปที่{0}'
skip: 'ไปที่ {0}'

Copilot uses AI. Check for mistakes.
shortDateFormat: 'dd/MM/yyyy',
shortTimeFormat: 'HH:mm',

dateLocale: th as any
Copy link

Copilot AI May 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using 'any' for dateLocale. Consider importing and using the proper Locale type from date-fns (e.g., dateLocale: th as Locale).

Copilot uses AI. Check for mistakes.
@simonguo simonguo merged commit 91a7a45 into rsuite:main May 27, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants