fix(InlineEdit): reset input value to original on cancel instead of preserving edited value #4283
Conversation
…reserving edited value
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the issue where the InlineEdit component preserved the edited input value on cancel instead of reverting to the original. It updates the focus handler to only trigger when appropriate and adds new test cases to ensure onFocus is only called once when the component is already in editing mode.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/InlineEdit/useEditState.ts | Modified the focus handler to check for an active edit state before firing onFocus. |
| src/InlineEdit/test/InlineEditSpec.tsx | Added tests to verify focus behavior, ensuring onFocus is only called on initial focus. |
Comments suppressed due to low confidence (1)
src/InlineEdit/test/InlineEditSpec.tsx:173
- Consider adding a test case that explicitly verifies the cancel action resets the input value to its original state, ensuring the bug is fully addressed.
it('Should have a custom size', () => {
2 participants
This PR fixes an issue in the InlineEdit component where the current input value was incorrectly preserved after triggering the onCancel callback.
Previously, when onCancel was called, the value that had been modified in the input field was stored and reused, instead of reverting to the original unedited value.
The component now correctly resets the input to its initial value when canceling an edit.
Related issue: #4274
Screen.Recording.2025-05-10.at.12.27.07.AM.mov