Repository navigation
ensure CXX is used to link the final shared object - #104
Merged
Merged
Conversation
|
|
Contributor
Author
|
(I can't seem to sign the CLA, I just get a window with a select box that won't let me choose anything) |
Collaborator
|
Thanks! |
paleolimbot
added a commit
to apache/arrow
that referenced
this pull request
Aug 24, 2022
#12824) In ARROW-15857 (#12734) we fixed the nightly failures on rhub/fedora-clang-devel by a kludge modifying the default makefile, but also upstreamed the fixes (rstudio/sass#104 and r-hub/rhub-linux-builders#60). These upstreams are now both released, so we can remove the kludge from modification of the docker image. Lead-authored-by: Dewey Dunnington <[email protected]> Co-authored-by: Dewey Dunnington <[email protected]> Signed-off-by: Dewey Dunnington <[email protected]>
zagto
pushed a commit
to zagto/arrow
that referenced
this pull request
Oct 7, 2022
apache#12824) In ARROW-15857 (apache#12734) we fixed the nightly failures on rhub/fedora-clang-devel by a kludge modifying the default makefile, but also upstreamed the fixes (rstudio/sass#104 and r-hub/rhub-linux-builders#60). These upstreams are now both released, so we can remove the kludge from modification of the docker image. Lead-authored-by: Dewey Dunnington <[email protected]> Co-authored-by: Dewey Dunnington <[email protected]> Signed-off-by: Dewey Dunnington <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #94, which is a similar problem to one we see in 'arrow' when compiling with slightly different C++ flags (in our case,
-stdlib=libc++to replicate the custom clang build that exists on fedora-clang-devel; see apache/arrow#12734). The final .so is getting linked with CC instead of CXX because there are no .cpp files (I think). This PR just renames init.c to init.cpp and includes the relevant changes to make sure that compile.c/compile.h work as they did before.With reprex: