Skip to content

Fix compilation warnings with gcc-12 - #100

Merged
cpsievert merged 3 commits into
mainfrom
joe/misc/gcc-12
Mar 21, 2022
Merged

cpsievert merged 3 commits into
mainfrom
joe/misc/gcc-12

Conversation

@jcheng5

@jcheng5 jcheng5 commented Mar 18, 2022

Copy link
Copy Markdown
Member

Requested by CRAN.

jcheng5 added 2 commits March 18, 2022 15:01
e.g.:
  src/lexer.hpp:89:15: warning: the address of ‘Sass::Constants::warn_kwd’ will never be NULL [-Waddress]
@jcheng5
jcheng5 requested a review from wch March 18, 2022 22:34
@jcheng5

jcheng5 commented Mar 18, 2022

Copy link
Copy Markdown
Member Author

Tested with this dockerfile:

FROM rocker/r-edge:gcc-12

RUN apt-get -y update
RUN apt-get -y install git
RUN R --slave -e "install.packages('knitr')"
RUN R --slave -e "install.packages('sass')"
RUN apt-get -y install libcurl4-openssl-dev
RUN R --slave -e "install.packages(c('testthat', 'rmarkdown', 'withr', 'shiny', 'curl'))"
RUN apt-get -y install pandoc
RUN mkdir /root/.R
RUN echo "CFLAGS +=              -O3 -Wall -pipe -pedantic -std=gnu99" > /root/.R/Makevars
RUN echo "CXXFLAGS +=            -O3 -Wall -pipe -Wno-unused -pedantic" >> /root/.R/Makevars

# git clone https://github.com/rstudio/sass && R CMD build --no-build-vignettes --no-manual sass && R CMD check sass*.tar.gz

@wch wch left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

It's strange that CRAN has decided to treat this warning as significant, but I guess we just have to deal with it.

@jcheng5

jcheng5 commented Mar 19, 2022

Copy link
Copy Markdown
Member Author

@wch @schloerke Any idea about the GHA failures? Especially the R 3.6/Windows one?

@schloerke

Copy link
Copy Markdown
Collaborator

Windows is a "make can't find file". I've not seen that error before. Don't know why the compilation isn't happening.

The pkgdown error is failing with feature request GitHub file. Did something change or is it malformed?

@cpsievert

cpsievert commented Mar 21, 2022 •

Copy link
Copy Markdown
Contributor

Merging since 4810f8d fixes the pkgdown error and I don't think Win 3.6 has ever passed for sass because of Make no being included in RTools for some reason. Thank you!

@cpsievert
cpsievert merged commit 207847a into main Mar 21, 2022
@cpsievert
cpsievert deleted the joe/misc/gcc-12 branch March 21, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants