Repository navigation
Fix compilation warnings with gcc-12 - #100
Merged
Merged
Conversation
e.g.: src/lexer.hpp:89:15: warning: the address of ‘Sass::Constants::warn_kwd’ will never be NULL [-Waddress]
Member
Author
|
Tested with this dockerfile: |
wch
approved these changes
Mar 19, 2022
wch
left a comment
Collaborator
There was a problem hiding this comment.
Looks good!
It's strange that CRAN has decided to treat this warning as significant, but I guess we just have to deal with it.
Member
Author
|
@wch @schloerke Any idea about the GHA failures? Especially the R 3.6/Windows one? |
Collaborator
|
Windows is a "make can't find file". I've not seen that error before. Don't know why the compilation isn't happening. The pkgdown error is failing with feature request GitHub file. Did something change or is it malformed? |
cpsievert
force-pushed
the
joe/misc/gcc-12
branch
from
March 21, 2022 15:41
9d57c57 to
4810f8d
Compare
Contributor
|
Merging since 4810f8d fixes the pkgdown error and I don't think Win 3.6 has ever passed for sass because of Make no being included in RTools for some reason. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by CRAN.