warning: loop variable ‘numerator’ creates a copy from type #122

Activity

1. wch commented on Jan 11, 2023

   

   wch

   on Jan 11, 2023

   Collaborator

   More actions

   I think this change should fix it (though I haven't tested yet):

   --- a/src/libsass/src/ast_values.cpp
   +++ b/src/libsass/src/ast_values.cpp
   @@ -481,9 +481,9 @@ namespace Sass {
      {
        if (hash_ == 0) {
          hash_ = std::hash<double>()(value_);
   -      for (const auto numerator : numerators)
   +      for (const auto& numerator : numerators)
            hash_combine(hash_, std::hash<sass::string>()(numerator));
   -      for (const auto denominator : denominators)
   +      for (const auto& denominator : denominators)
            hash_combine(hash_, std::hash<sass::string>()(denominator));
        }
        return hash_;
2. cpsievert

   added a commit that references this issue on Jan 11, 2023

   Upgrade libsass from 3.6.4 to 3.6.5

   ...

   This issue will close once commit 6cb8239 is merged into the 'main' branch.

   6cb8239
3. cpsievert commented on Jan 11, 2023

   

   cpsievert

   on Jan 11, 2023

   ContributorAuthor

   More actions

   Yep, thanks, I noticed LibSass 3.6.5 addressed it in sass/libsass#3129, so I'm thinking we just update LibSass (#123)?
4. wch commented on Jan 11, 2023

   

   wch

   on Jan 11, 2023

   Collaborator

   More actions

   That's a good idea. I didn't realize that we weren't on the latest version of libsass.
5. cpsievert

   closed this as completedin #123on Jan 12, 2023
6. cpsievert

   added a commit that references this issue on Jan 12, 2023

   Upgrade libsass from 3.6.4 to 3.6.5 (#123)

   ...

   This issue will close once commit fe83296 is merged into the 'main' branch.

   fe83296