Fix regression w/ image path processing from absolute to relative#2554
Merged
Fix regression w/ image path processing from absolute to relative#2554
Conversation
Processing of HTML needs to account for newlines because pandoc --wrap behavior can sometimes likes to split lines in the HTML like ``` <img> src="..." </img> ``` Processing line by line would break a reg for img tag's src attribute This breakage was found in pkgdown processing which uses absolute path for rendering leading to very long image source creating the split
- For generic case with plot - With a specific case of pandoc markdown syntax + absolute path This adds xml2 as suggest for testing
cderv
changed the title
This was referenced Apr 30, 2024
cderv
changed the title
Contributor
|
It has been almost two months since the last release, so we can plan for a new CRAN release soon (depending on whether we have other stuff that should go with this release). |
jonathan-g
added a commit
to jonathan-g/rmarkdown
that referenced
this pull request
Aug 8, 2024
Merge remote-tracking branch 'rstudio/main' into jg-devel # By Yihui Xie (10) and others # Via GitHub * rstudio/main: Fix Pandoc nightly install in GHA (rstudio#2559) feat(beamer): support latex_dependencies (rstudio#2558) start the next version CRAN release 2.27 export S3 method rsconnect::deploySite() has combined the arguments account and server in the doc Update forum url (rstudio#2555) Fix regression w/ image path processing from absolute to relative (rstudio#2554) Update posit forum URL provide an option to set the `*_files/` directory suffix (rstudio#2550) start the next version CRAN release v2.26 use _PACKAGE as recommended by roxygen2 use \describe{} instead of \itemize{} (r-devel will warn against it) [GHA] Remove duplicate entry in matrix new r-lib/actions@v2 has newer setup-pandoc [GHA] New setup pandoc action (rstudio#2543) Correctly avoid writing to the input file when there are no preserved HTML chunks (rstudio#2535) Create FUNDING.yml Fix small grammatical error (rstudio#2533) # Conflicts: # DESCRIPTION # R/publish_site.R
jonathan-g
added a commit
to jonathan-g/rmarkdown
that referenced
this pull request
Aug 8, 2024
* jg-devel: (21 commits) Builds and passes R CMD CHECK. Fix Pandoc nightly install in GHA (rstudio#2559) feat(beamer): support latex_dependencies (rstudio#2558) start the next version CRAN release 2.27 export S3 method rsconnect::deploySite() has combined the arguments account and server in the doc Update forum url (rstudio#2555) Fix regression w/ image path processing from absolute to relative (rstudio#2554) Update posit forum URL provide an option to set the `*_files/` directory suffix (rstudio#2550) start the next version CRAN release v2.26 use _PACKAGE as recommended by roxygen2 use \describe{} instead of \itemize{} (r-devel will warn against it) [GHA] Remove duplicate entry in matrix new r-lib/actions@v2 has newer setup-pandoc [GHA] New setup pandoc action (rstudio#2543) Correctly avoid writing to the input file when there are no preserved HTML chunks (rstudio#2535) Create FUNDING.yml ...
jonathan-g
added a commit
to jonathan-g/rmarkdown
that referenced
this pull request
Aug 8, 2024
* rstudio/main: Fix Pandoc nightly install in GHA (rstudio#2559) feat(beamer): support latex_dependencies (rstudio#2558) start the next version CRAN release 2.27 export S3 method rsconnect::deploySite() has combined the arguments account and server in the doc Update forum url (rstudio#2555) Fix regression w/ image path processing from absolute to relative (rstudio#2554) Update posit forum URL provide an option to set the `*_files/` directory suffix (rstudio#2550) start the next version CRAN release v2.26 use _PACKAGE as recommended by roxygen2 use \describe{} instead of \itemize{} (r-devel will warn against it) [GHA] Remove duplicate entry in matrix new r-lib/actions@v2 has newer setup-pandoc [GHA] New setup pandoc action (rstudio#2543) Correctly avoid writing to the input file when there are no preserved HTML chunks (rstudio#2535) Create FUNDING.yml Fix small grammatical error (rstudio#2533)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Processing of HTML needs to account for newlines because pandoc --wrap behavior can sometimes likes to split lines in the HTML like
Processing line by line would break a reg for img tag's src attribute
This breakage was found in pkgdown processing which uses absolute path for rendering leading to very long image source creating the split
It is also related to
knitr.graphics.rel_path = FALSEbeing set froRelated to
knitr.graphics.rel_path = FALSEdue to default relative path processing ininclude_graphics()can create broken path yihui/knitr#2171)knitr.graphics.rel_path = FALSEdue to default relative path processing ininclude_graphics()can create broken path yihui/knitr#2171)See discussion in 0951a2f