Merged
Conversation
This was referenced Jan 17, 2024
yihui
approved these changes
Jan 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit-test for this particular user-case.
Running
pandocis unfortunately necessary.Tested on CRAN version of
rmarkdownand a dev version using this fork.In case of CRAN version,
pandocalso likes to throw some additional warnings and errors that cannot be suppressed (or at least I don't know how).If a
withr::with_tempfile()is required instead ofon.exit(), I can rework this. Sinceon.exitis already used in this file, I thought that it won't be confusing.