fix: apply pandoc div.sourceCode style to pre.sourceCode instead #1598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Note:
This is because of following css embedded by pandoc. pre.numberSource code > span > a:first-child::before
{ content: counter(source-line);
position: relative; left: -1em; text-align: right; vertical-align: baseline;
border: none; display: inline-block;
-webkit-touch-callout: none; -webkit-user-select: none;
-khtml-user-select: none; -moz-user-select: none;
-ms-user-select: none; user-select: none;
padding: 0 4px; width: 4em;
background-color: #ffffff;
color: #a0a0a0;
} |
atusy
added a commit
to atusy/rmarkdown
that referenced
this pull request
Jul 7, 2019
Because this is fixed by PR rstudio#1598
yihui
approved these changes
Jul 10, 2019
Contributor
yihui
left a comment
yihui
left a comment
There was a problem hiding this comment.
Seems to be reasonable. Thank you!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a generalization of a0c0c68 (#1471)
Currently, JS converts
background-colorandcolorproperties ofdiv.sourceCodetopre.sourceCodeand delete the formers iff the both properties are specified fordiv.sourceCodeThus,
highlight: tangowiththeme: darklyclearly shows thatdiv.source {background: f8f8f8}is active.(
tangoonly specifiedbackground-colornotcolor)By this PR, output becomes
Source