Security patch: Updates jquery version with 3.5.0 #882
+3
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I received a GitHub security alert with a suggested remediation to update jquery to 3.5.0. This is the only place in bookdown that I could find an opportunity to do so.
yihui
reviewed
May 6, 2020
Contributor
yihui
left a comment
yihui
left a comment
There was a problem hiding this comment.
Bumping the version number is not enough. We also need to actually include a copy of jquery.min.js: https://github.com/rstudio/bookdown/tree/master/inst/resources/jquery Thanks!
yihui
reviewed
May 6, 2020
Author
|
Would you like me to add and commit? |
Author
|
I have replaced jquery.min.js v2.2.3 with v.3.5.0. All tests have passed. I have done a global search in the repo for the string "jquery" Two questions:
|
3 tasks
|
|
Contributor
|
This has been done in #693. To answer your two questions (if you still need the answers):
Thank you very much! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I received a GitHub security alert with a suggested remediation to update jquery to 3.5.0.
This is the only place in bookdown that I could find an opportunity to do so.