Allow rmd_subdir to be either a bool or list of subdirectories.
#561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If `rmd_subdir` is true then bookdown searches for files *recursively* from the project root directory. - If `rmd_subdir` is a list of subdirectories then bookdown search for files *recursively* from each subdirectory. Fixes #242
yihui
approved these changes
Apr 4, 2018
Contributor
yihui
left a comment
yihui
left a comment
There was a problem hiding this comment.
Looks good to me. Could you add a bullet to NEWS.md, add your name to DESCRIPTION (alphabetical order by first name), and also update the documentation https://github.com/rstudio/bookdown/blob/master/inst/examples/04-customization.Rmd#configuration ? Thanks!
yihui
added a commit
that referenced
this pull request
Apr 4, 2018
Contributor
|
Could you also post an answer to SO: https://stackoverflow.com/q/40578609/559676? Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
If
rmd_subdiris true then bookdown searches for files recursively from the project root directory. Ifrmd_subdiris a list of subdirectories then bookdown search for files recursively from each subdirectory.I have submitted the individual contributor agreement and welcome feedback on this pull request.
Fixes #242