-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Revert and improve change on code block regarding scrolling #1204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 97f8da3.
apreshill
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Ok for the 50%. It looks ok ! For the margin around the button I thought I removed them. I'll look into it. Maybe bootstrap add some by default we need to reduce. |
I know understand you are talking about the margin of the pre, is that it ? The current margin on the pre create a gap between the button and the right side of the pre block when you add the red background. Currently,
What we could do is move the copy button to the right to be coherent with the pre background. |
|
If we want to reduce the red background padding, it would mean changing bootstrap default. Possibly this would need to be done at the bootstrap variable level maybe ?
I am tweaking a lot of things at CSS level currently, but we should leverage bslib better maybe. the |
apreshill
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
[skip ci]
[skip ci]




This reverts commit dc87225 (#1187) following discussion in #1040
Plan is to keep the scrolling but have the icon stays on the top right side even when scrolling.
The button icon will always show so there could be overlap with long line as we no more wrapp. However, the icon is a lighter option than a button, and by default there is an opacity filter. It will be darker on button hover only.
Demo here: https://cderv.github.io/bs4booktesting/with-scroll/