Skip to content

Conversation

@cderv
Copy link
Collaborator

@cderv cderv commented Jul 6, 2021

This offer support for collapse = FALSE and deal with one of the feedback from #1040

This is also the behavior from gitbook()

Testing site: https://cderv.github.io/bs4booktesting/nocopybuttononoutput/#collapse-true-vs-false

Must follow #1187 that should be merged into master then this branch updated

@cderv cderv added this to the v0.23 milestone Jul 6, 2021
@apreshill apreshill self-requested a review July 6, 2021 16:11
Copy link
Contributor

@apreshill apreshill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks!

[skip ci]
@cderv cderv merged commit fc329f7 into master Jul 6, 2021
@cderv cderv deleted the bs4book/nocopybuttononoutput branch July 6, 2021 17:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants