Skip to content

Add split_bib to bs4_book #1185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cderv merged 9 commits into from
Jul 23, 2021
Merged

Add split_bib to bs4_book #1185

cderv merged 9 commits into from
Jul 23, 2021
+14 −8

Conversation

@shirdekel
Copy link
Contributor

@shirdekel shirdekel commented Jun 24, 2021

@shirdekel shirdekel mentioned this pull request Jun 24, 2021
Closed
shirdekel added a commit to shirdekel/phd_thesis that referenced this pull request Jun 24, 2021
@shirdekel
Add chapter bibliography to bs4 output
9a3e279 
- Currently dependent on the split-bib branch.

- Submitted pull request (rstudio/bookdown#1185).
@cderv cderv linked an issue Jun 24, 2021 that may be closed by this pull request
[FR] Add split_bib to bs4_book #1146
Closed
cderv
cderv requested changes Jun 25, 2021
View reviewed changes
Copy link
Collaborator

@cderv cderv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a simple change.

Did you test it against your book ? Did you find any conflict with other features ?

Can you add a NEWS bullet too ?

As you added a new argument, you need to document so the CI tests do not error on doc mismatch.

There is also a conflict to solve because bs4_book() as evolved. Should be a simple one. Ping me if you need help with it.

thanks !

@shirdekel
Copy link
Contributor Author

shirdekel commented Jun 25, 2021

Looks like there's still an issue with the documentation. I tried looking at the gitbook.R docs but it's not documented there, only in html.R. Should I give it its own @param description as in html.R?

@cderv
Copy link
Collaborator

cderv commented Jul 6, 2021

Ok I'll have a look at the issue and do it. Thanks !

@cderv cderv mentioned this pull request Jul 23, 2021
Merged
4 tasks
@cderv cderv added the next to consider for next release label Jul 23, 2021
@cderv cderv added this to the v0.23 milestone Jul 23, 2021
cderv
cderv approved these changes Jul 23, 2021
View reviewed changes
Copy link
Collaborator

@cderv cderv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made the change. split_bib = TRUE will now be possible to specify in bs4_book().

This is useful when no CSL with footnote style for citations is used.
https://pkgs.rstudio.com/bookdown/reference/bs4_book.html#references-bibliography
In that case, split_bib = TRUE will do nothing.

When a CSL with footnote style is used, citations are set inline in a linked popup showing on click. This has the same intent a putting the references at the end of the chapter but using a different way to do it.

@cderv cderv merged commit 6ae8900 into rstudio:master Jul 23, 2021
@shirdekel shirdekel deleted the split-bib branch July 25, 2021 07:51
@cderv cderv mentioned this pull request Sep 6, 2021
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cderv cderv cderv approved these changes

Assignees

No one assigned

Labels

bs4_book 🥾 next to consider for next release

Projects

None yet

Milestone

v0.23

Development

Successfully merging this pull request may close these issues.

[FR] Add split_bib to bs4_book

2 participants

@shirdekel @cderv