bs4_book(): Make math work in footnotes
#1176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maelle
commented
Jun 14, 2021
maelle
commented
Jun 14, 2021
cderv
added a commit
to cderv/bookdown-demo
that referenced
this pull request
Jun 23, 2021
cderv
reviewed
Jun 23, 2021
cderv
reviewed
Jun 23, 2021
cderv
reviewed
Jun 23, 2021
cderv
reviewed
Jun 23, 2021
Collaborator
cderv
left a comment
cderv
left a comment
There was a problem hiding this comment.
I think this PR is fine. I asked just some last question before I merge.
Thanks
cderv
added a commit
to rstudio/bookdown-demo
that referenced
this pull request
Jun 23, 2021
* Add mention of bs4_book() in the demo output.yml * Add example on Math, including in footnotes. Related to rstudio/bookdown#1176
Co-authored-by: Christophe Dervieux <[email protected]>
…nks in the Github issue and commits Code is also modified in #1026 (comment)
cderv
approved these changes
Jun 25, 2021
Collaborator
cderv
left a comment
cderv
left a comment
There was a problem hiding this comment.
Thanks !
That seems to work well now !
Collaborator
|
Currently checking with @mine-cetinkaya-rundel if this fix the issues in her book. The opened issue was about this so it should at least work correctly there. |
|
Just tried it out and works for me as well, thank you! |
cderv
changed the title
bs4_book(): Make math work in footnotes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1026
Well, unless there's a way to have math paragraphs in footnotes (since I didn't find a way to add those, I didn't test their rendering).