bs4_book(): Fix alignment of text blocks within rmdnote divs
#1175
Conversation
cderv
left a comment
cderv
left a comment
There was a problem hiding this comment.
This will reduce the pre background and code won't be aligned anymore with the outside text
From the issue,
Code should occupy full width of block
Do we want either the opposite and get the pre background to be aligned with the other pre background outside of rmdnote box ?
To illustrate the above, with this PR here is what it looks like:
Code and text in the box are no more aligned which does not feel right to me.
Is the screenshot posted in #1084 what it should look like ? Because it seems that the link in mastering-shiny already looks like that.
Yes I guess I do not understand what the issue is. |
|
@maelle see answer in #1084 (comment)
So this PR is not yet quite right. Do you have time to change or should I do this ? |
|
cc @apreshill as we discussed it yesterday. |
|
Btw whilst looking at this on different screen sizes it made the need for a copy-button fix (to not make it hide code) look even more important. 😬 |
|
I think I would keep the code content align with the text content even if we make the background full width It would look like this |
|
what is your feeling on this one @apreshill ? I'll tweak the implementation following what we decide. |
|
I agree @cderv - I tend to prefer keeping the text aligned inside the note box. |
|
So background full width and text align it will be! Thanks. |
|
This will now look like this |
cderv
changed the title
bs4_book(): Fix alignment of text blocks within rmdnote divs
3 participants
Fix #1084 (if I understood the problem correctly)