bs4_book_page() knows html_cur and rmd_cur, so YAML could be used inside each Rmd 😸

not that helpful though

I am hoping is finding a way to add the current Rmd as a comment / special div, and then use that when tweaking to go read YAML in the original Rmd file...

each H1 would need some sort of Rmd info attached to them as data attribute 🤔

Compromise I'll implement next week (after discussion with @cderv) if ok with you @apreshill

• cover-image used for all pages.
• I'll check whether og:url is useless, otherwise build it from the main url & path.
• title will be set to the first H1 + maybe with the book title.
• description will be the truncated content.

So the idea would be to have no customization via YAML as it seemed complex. 🤔

Hi- this sounds very good to me, and I agree with not adding any per-chapter YAMLs since that it so ingrained into bookdown. I like the Description idea- reminds me of Hugo's auto summary variable (https://gohugo.io/content-management/summaries/#automatic-summary-splitting).

reminds me of Hugo's auto summary variable (gohugo.io/content-management/summaries/#automatic-summary-splitting).

guess where I got the idea from 😜

Noting that og:url is compulsory https://developers.facebook.com/docs/sharing/webmasters#basic

Overall, I think we need to understand better how opengraph is really generated to be sure to set the correct value. Some comment on the above.

cover-image used for all pages.

👍

I'll check whether og:url is useless, otherwise build it from the main url & path.

I think it will be set to the url of the page by default in most case. Some OG simulator for twitter and facebook do for example. but it seems mandatory (better practice) in the resource I read. This could be possible to set / modify when splitting happen in bookdown.

title will be set to the first H1 + maybe with the book title.

<title> is already set. The same value is used already when splitting chapter (see prepend_chapter_title() used in split_chapter()

description will be the truncated content.

It may be important that description can be set globally too. Like in gitbook() in description yaml field in index.Rmd - it is possible that some user would prefer to have the same description for the book as a whole even if some chapter are shared with a specific url. Books are special website and I think it make sense to still have this possibility. If unset, then if we manage to get a content automatically from a page, then we can use that. But it may not be a good description content for some pages and worse than having no description (just image, title and link) sometimes.

With @maelle we also discussed the possibility of setting information for each html file in some way, but it is hard with the current design which merge then split, and not header in YAML file except index.Rmd. bs4_book() could be easier as 1 Rmd = 1 file but it is not the case for gitbook().

Maybe another parameter is needed (but in which file 🙃 ) to choose whether the general description should apply to all pages or just the index.html 🤔

Maybe another parameter is needed (but in which file upside_down_face ) to choose whether the general description should apply to all pages or just the index.html thinking

@cderv do you disagree with this? At the moment my PR doesn't let one use the same description for all pages.

Hi @maelle - if I'm following this right, the twitter description won't update per chapter, but the og will be per chapter? I've mainly seen those match - is there a reason to not have per chapter twitter descriptions?

@apreshill No, I had missed it! Thanks for catching this! Now I am wondering whether the Twitter and OG descriptions should have different lengths, maybe simpler to keep them the same for now?

Will do this afternoon. In the meantime, here was my testing repo in case it is helpful: https://github.com/apreshill/bs4booktesting

Tested with https://github.com/cderv/bs4booktesting, a fork of yours as I don't have access. Published here: https://cderv.github.io/bs4booktesting/

This looks good now I believe

I also checked that Zotero connector is working now (fix #1080)

We are all set and ready to merge. ok for you @apreshill ?