-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Description
All the icons automatically injected into the bookdown GitBook header should have alt/hover text. Here is the header from the bookdown book itself: https://bookdown.org/yihui/bookdown/

Some of the elements have aria-label, but that is for assistive technologies, not most browsers / viewers. Bookdown should additionally give those elements title to describe the buttons for folks who hover to understand the underlying functionality.
Consider this example from the RStudio Connect documentation; many viewers may not understand that the "A" is for text resizing and the PDF logo is a PDF logo (Adobe Acrobat?) that triggers a file download.

This issue is present in many bookdown versions, including bookdown 0.9.
By filing an issue to this repo, I promise that
- I have fully read the issue guide at https://yihui.name/issue/.
- I have provided the necessary information about my issue.
- If I'm asking a question, I have already asked it on Stack Overflow or RStudio Community, waited for at least 24 hours, and included a link to my question there.
- If I'm filing a bug report, I have included a minimal, self-contained, and reproducible example, and have also included
xfun::session_info('bookdown'). I have upgraded all my packages to their latest versions (e.g., R, RStudio, and R packages), and also tried the development version:remotes::install_github('rstudio/bookdown'). - If I have posted the same issue elsewhere, I have also mentioned it in this issue.
- I have learned the Github Markdown syntax, and formatted my issue correctly.