-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Closed
Milestone
Description
- Visit a bookdown-built book deployed to an HTTP server, such as: https://docs.rstudio.com/connect/admin/
- Use the 'f' keyboard shortcut to open the search input dialog.
- Type in a search phrase; try "safari".
- Now, visit another bookdown-built book deployed to the same HTTP server, such as:
https://docs.rstudio.com/ide/server-pro/ - Observe that the search term "safari" is automatically active in this second book.
This appears to be a long-standing issue. The RStudio IDE Server Pro documentation was built with bookdown 0.1 (according to the HTML metadata). The RStudio Connect Admin Guide was built with a pinned git SHA close to bookdown 0.7.7. I am actively updating to bookdown 0.9 and still see search phrases persisting across page loads.
I understand why local storage is being used to maintain search phrases - different portions of a book may reside in different HTML and the search phrase needs to persist as matching chapters/sections are visited.
Scenarios to consider:
- Multiple books hosted on the same domain. Search should not persist when following links between books.
- Multiple tabs open against the same book. Search in one tab should not persist when a second tab is opened against the same book.
- Revisiting a book after time has passed. Search should not persist when returning to that book at some later time.
All three of these scenarios persist search terms today in both the RSP and RStudio Connect documentation.
- I have fully read the issue guide at https://yihui.name/issue/.
- I have provided the necessary information about my issue.
- If I'm asking a question, I have already asked it on Stack Overflow or RStudio Community, waited for at least 24 hours, and included a link to my question there.
- If I'm filing a bug report, I have included a minimal, self-contained, and reproducible example, and have also included
xfun::session_info('bookdown'). I have upgraded all my packages to their latest versions (e.g., R, RStudio, and R packages), and also tried the development version:remotes::install_github('rstudio/bookdown'). - If I have posted the same issue elsewhere, I have also mentioned it in this issue.
- I have learned the Github Markdown syntax, and formatted my issue correctly.
kellobri
Metadata
Metadata
Assignees
Labels
No labels