Skip to content

Comments

fix: update peerDependencies for @rspack/core to support v2#70

Merged
chenjiahan merged 1 commit intomainfrom
update_peer_0116
Jan 16, 2026
Merged

fix: update peerDependencies for @rspack/core to support v2#70
chenjiahan merged 1 commit intomainfrom
update_peer_0116

Conversation

@chenjiahan
Copy link
Member

Update peerDependencies for @rspack/core to support v2.

Copilot AI review requested due to automatic review settings January 16, 2026 08:23
@chenjiahan chenjiahan merged commit 468d0ab into main Jan 16, 2026
13 checks passed
@chenjiahan chenjiahan deleted the update_peer_0116 branch January 16, 2026 08:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the @rspack/core peer dependency to support version 2.x in addition to the existing 1.x support.

Changes:

  • Updated the @rspack/core peer dependency version range from ^1.0.0 to ^1.0.0 || ^2.0.0 || ^2.0.0-0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

},
"peerDependencies": {
"@rspack/core": "^1.0.0"
"@rspack/core": "^1.0.0 || ^2.0.0 || ^2.0.0-0"
Copy link

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version range specification contains redundant patterns. The range ^2.0.0 already includes all stable versions from 2.0.0 onwards (including 2.0.1, 2.1.0, etc.), so adding ^2.0.0-0 is redundant because ^2.0.0 will already match any stable 2.x version. If the intention is to support pre-release versions of 2.0.0, consider using ^1.0.0 || >=2.0.0-0 <3.0.0-0 which more clearly expresses support for v1.x and all v2.x versions including pre-releases.

Suggested change
"@rspack/core": "^1.0.0 || ^2.0.0 || ^2.0.0-0"
"@rspack/core": "^1.0.0 || >=2.0.0-0 <3.0.0-0"

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant