fix: update peerDependencies for @rspack/core to support v2#70
fix: update peerDependencies for @rspack/core to support v2#70chenjiahan merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request updates the @rspack/core peer dependency to support version 2.x in addition to the existing 1.x support.
Changes:
- Updated the
@rspack/corepeer dependency version range from^1.0.0to^1.0.0 || ^2.0.0 || ^2.0.0-0
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| }, | ||
| "peerDependencies": { | ||
| "@rspack/core": "^1.0.0" | ||
| "@rspack/core": "^1.0.0 || ^2.0.0 || ^2.0.0-0" |
There was a problem hiding this comment.
The version range specification contains redundant patterns. The range ^2.0.0 already includes all stable versions from 2.0.0 onwards (including 2.0.1, 2.1.0, etc.), so adding ^2.0.0-0 is redundant because ^2.0.0 will already match any stable 2.x version. If the intention is to support pre-release versions of 2.0.0, consider using ^1.0.0 || >=2.0.0-0 <3.0.0-0 which more clearly expresses support for v1.x and all v2.x versions including pre-releases.
| "@rspack/core": "^1.0.0 || ^2.0.0 || ^2.0.0-0" | |
| "@rspack/core": "^1.0.0 || >=2.0.0-0 <3.0.0-0" |
Update peerDependencies for @rspack/core to support v2.