Skip to content

Handle basic auth using the syntax appropiate to the Faraday version#232

Merged
jcoyne merged 1 commit intomasterfrom
faraday-basic-auth
Feb 11, 2022
Merged

Handle basic auth using the syntax appropiate to the Faraday version#232
jcoyne merged 1 commit intomasterfrom
faraday-basic-auth

Conversation

@cbeer
Copy link
Copy Markdown
Contributor

@cbeer cbeer commented Feb 11, 2022

Addresses some deprecation warnings in Faraday 1.x, and makes requests with basic auth work with Faraday 2.x:

WARNING: `Faraday::Connection#basic_auth` is deprecated; it will be removed in version 2.0.
While initializing your connection, use `#request(:basic_auth, ...)` instead.
See https://lostisland.github.io/faraday/middleware/authentication for more usage info.

@cbeer cbeer force-pushed the faraday-basic-auth branch from 49bf742 to 35e4822 Compare February 11, 2022 18:55
@jcoyne jcoyne merged commit b351328 into master Feb 11, 2022
@jcoyne jcoyne deleted the faraday-basic-auth branch February 11, 2022 18:58
@whereismyjetpack whereismyjetpack mentioned this pull request Apr 7, 2022
Merged
@ykitamura-mdsol ykitamura-mdsol mentioned this pull request Apr 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcoyne jcoyne jcoyne approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cbeer @jcoyne