Update libffi to 4.0.0 #209
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LIbffi is broken in MacOS 15+. The clang compiler that comes with Xcode that comes with MacOS 15 is incompatible with libffi 3.2.0. There has been a fix, and it is updated in libffi 4.0.0. See libffi-rs/libffi-rs#109
jedbrown
reviewed
Apr 21, 2025
Contributor
jedbrown
left a comment
jedbrown
left a comment
There was a problem hiding this comment.
Thanks, I started the pipeline. Is it worth changing CI (.github/workflows/test.yaml) so that this would be tested?
Contributor
|
I fixed CI issues. Can you please rebase on main? |
Author
|
Done! |
Contributor
|
This bumps MSRV to 1.78. You can update the |
jedbrown
reviewed
May 23, 2025
Cargo.toml
Outdated
| [dependencies] | ||
| conv = "0.3.3" | ||
| libffi = { version = "3.2.0", optional = true } | ||
| libffi = { version = "4.0.0", optional = true } |
Contributor
There was a problem hiding this comment.
Suggested change
| libffi = { version = "4.0.0", optional = true } | |
| libffi = { version = "4.1.0", optional = true } |
I see a new version is out. And please update the rust-version field; then we should be able to merge this.
jedbrown
added a commit
that referenced
this pull request
Jun 6, 2025
The updated libffi is needed to fix an issue with MacOS 15, and the fix has a side-effect of increasing MSRV to 1.78. See #209
jedbrown
added a commit
that referenced
this pull request
Jun 6, 2025
The updated libffi is needed to fix an issue with MacOS 15, and the fix has a side-effect of increasing MSRV to 1.78. See #209 We will stick with bindgen-1.70.1 because bindgen-1.71.1 does not correctlly identify when to avoid using unsafe extern "C" { ... }, which was first added in rust-1.82. rust-lang/rust-bindgen#3015 https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-extern.html
jedbrown
added a commit
that referenced
this pull request
Jun 10, 2025
The updated libffi is needed to fix an issue with MacOS 15, and the fix has a side-effect of increasing MSRV to 1.78. See #209 We will stick with bindgen-1.70.1 because bindgen-1.71.1 does not correctlly identify when to avoid using unsafe extern "C" { ... }, which was first added in rust-1.82. rust-lang/rust-bindgen#3015 https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-extern.html
jedbrown
added a commit
that referenced
this pull request
Jun 10, 2025
The updated libffi is needed to fix an issue with MacOS 15, and the fix has a side-effect of increasing MSRV to 1.78. See #209 We will stick with bindgen-1.70.1 because bindgen-1.71.1 does not correctlly identify when to avoid using unsafe extern "C" { ... }, which was first added in rust-1.82. rust-lang/rust-bindgen#3015 https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-extern.html
Changed libffi version to 4.1.0 in Cargo.toml
Incremented libffi version
Contributor
|
Closing in favor of #214 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LIbffi is broken in MacOS 15+. The clang compiler that comes with Xcode that comes with MacOS 15 is incompatible with libffi 3.2.0.
There has been a fix, and it is updated in libffi 4.0.0. See libffi-rs/libffi-rs#109