Conversation
koic
added a commit
to koic/oracle-enhanced
that referenced
this pull request
May 24, 2020
RuboCop Performance 1.6.0 has been released. https://github.com/rubocop-hq/rubocop-performance/releases/tag/v1.6.0 This PR suppresss new RuboCop's offenses. ```consle % bundle exec rubocop (snip) Offenses: lib/active_record/connection_adapters/oracle_enhanced/database_statements.rb:45:39: C: Performance/StartWith: Use String#start_with? instead of a regex match anchored to the beginning of the string. if (name == "EXPLAIN") && sql =~ /^EXPLAIN/ ^^^^^^^^^^^^^^^^^ lib/active_record/connection_adapters/oracle_enhanced/lob.rb:21:15: C: Performance/EndWith: Use String#end_with? instead of a regex match anchored to the end of the string. column.sql_type_metadata.sql_type =~ /LOB$/ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ lib/active_record/connection_adapters/oracle_enhanced/oci_connection.rb:327:46: C: Performance/StartWith: Use String#start_with? instead of a regex match anchored to the beginning of the string. database = "/#{database}" unless database.match?(/^\//) ^^^^^^^^^^^^^^^^^^^^^^ spec/active_record/connection_adapters/oracle_enhanced/connection_spec.rb:183:58: C: Performance/StartWith: Use String#start_with? instead of a regex match anchored to the beginning of the string. params[:database] = "/#{params[:database]}" unless params[:database].match?(/^\//) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 70 files inspected, 4 offenses detected ``` rsim#2019
Collaborator
Author
|
CI has been failed. RuboCop offenses will be solved by #2020 and the following |
Collaborator
|
The second part of CI depends on the master branch of Oracle enhanced adapter, then once this pull request merged, the next CI should be green. |
Collaborator
|
Thanks for the recent active contributions. |
yahonda
added a commit
to yahonda/oracle-enhanced
that referenced
this pull request
Sep 10, 2020
This pull request restores Schema Dumper behavior changed by rsim#2019 because rails/rails#39365 does not intend to dump the default primary key configuration. Related to rails/rails#39365 Follow up rsim#2019
yahonda
added a commit
to yahonda/oracle-enhanced
that referenced
this pull request
Sep 10, 2020
This pull request restores Schema Dumper behavior changed by rsim#2019 because rails/rails#39365 does not intend to dump the default primary key configuration. Related to rails/rails#39365 Follow up rsim#2019
yahonda
added a commit
to yahonda/oracle-enhanced
that referenced
this pull request
Sep 11, 2020
This pull request restores Schema Dumper behavior changed by rsim#2019 because rails/rails#39365 does not intend to dump the default primary key configuration. To avoid hash creation every time, it has been frozen and saved as a constant. Related to rails/rails#39365 Follow up rsim#2019 Refer http://code.jeremyevans.net/presentations/rubykaigi2019/index.html#58
yahonda
added a commit
to yahonda/oracle-enhanced
that referenced
this pull request
Sep 11, 2020
This pull request restores Schema Dumper behavior changed by rsim#2019 because rails/rails#39365 does not intend to dump the default primary key configuration. To avoid hash creation every time, it has been frozen and saved as a constant. Related to rails/rails#39365 Follow up rsim#2019 Refer http://code.jeremyevans.net/presentations/rubykaigi2019/index.html#58
koic
added a commit
that referenced
this pull request
Sep 11, 2020
Restore Schema Dumper behavior changed by #2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to rails/rails#39365.
This PR consists of the following two commits.
ENGINE=InnoDBis no longer dumped to make schema more agnostic (rails/rails@3c6be5e)The latter changes
create_tableformat in the dumped schema file.