Updated implementation that doesn't depend directly on FFI.#3
Merged
Updated implementation that doesn't depend directly on FFI.#3
Conversation
nsaunders
force-pushed
the
no-ffi-needed
branch
from
d192c64 to
93e9018
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
By leveraging the
uniqueandordered-collectionspackages, this updated implementation eliminates the need for FFI.Checklist:
Linked any existing issues or proposals that this pull request should closeN/AUpdated or added relevant documentation in the README and/or documentation directoryN/AAdded a test for the contribution (if applicable)Not really necessary due to existing test coverage.